Commit 5d4c1edf authored Nov 06, 2020 by Deepak R Varma Committed by Gerd Hoffmann Nov 06, 2020

drm/qxl: replace idr_init() by idr_init_base()

idr_init() uses base 0 which is an invalid identifier for this driver.
The idr_alloc for this driver uses 1 as start value for ID range. The
new function idr_init_base allows IDR to set the ID lookup from base 1.
This avoids all lookups that otherwise starts from 0 since 0 is always
unused / available.

References: commit 6ce711f2 ("idr: Make 1-based IDRs more efficient")

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20201105185016.GA71797@localhost

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

parent 44510939

drivers/gpu/drm/qxl/qxl_kms.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -231,11 +231,11 @@ int qxl_device_init(struct qxl_device *qdev,
		goto cursor_ring_free;
		}

		idr_init(&qdev->release_idr);
		idr_init_base(&qdev->release_idr, 1);
		spin_lock_init(&qdev->release_idr_lock);
		spin_lock_init(&qdev->release_lock);

		idr_init(&qdev->surf_id_idr);
		idr_init_base(&qdev->surf_id_idr, 1);
		spin_lock_init(&qdev->surf_id_idr_lock);

		mutex_init(&qdev->async_io_mutex);