Commit 5d296cc9 authored Apr 09, 2020 by Jason Yan Committed by Martin K. Petersen Apr 14, 2020

scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static

Fix the following sparse warning:

drivers/scsi/qla1280.c:529:1: warning: symbol 'qla1280_firmware_mutex'
was not declared. Should it be static?
drivers/scsi/qla1280.c:538:15: warning: symbol 'qla1280_fw_tbl' was not
declared. Should it be static?

Link: https://lore.kernel.org/r/20200409084910.44336-1-yanaijie@huawei.com


Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 1909a438

drivers/scsi/qla1280.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -526,7 +526,7 @@ static struct pci_device_id qla1280_pci_tbl[] = {
		};
		MODULE_DEVICE_TABLE(pci, qla1280_pci_tbl);

		DEFINE_MUTEX(qla1280_firmware_mutex);
		static DEFINE_MUTEX(qla1280_firmware_mutex);

		struct qla_fw {
		char *fwname;
		@@ -535,7 +535,7 @@ struct qla_fw {

		#define QL_NUM_FW_IMAGES 3

		struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = {
		static struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = {
		{"qlogic/1040.bin", NULL}, /* image 0 */
		{"qlogic/1280.bin", NULL}, /* image 1 */
		{"qlogic/12160.bin", NULL}, /* image 2 */

Admin message