Commit 5d28913d authored Nov 19, 2020 by Alex Elder Committed by Jakub Kicinski Nov 20, 2020

net: ipa: don't reset an ALLOCATED channel



If the rmnet_ipa0 network device has not been opened at the time
we remove or shut down the IPA driver, its underlying TX and RX
GSI channels will not have been started, and they will still be
in ALLOCATED state.

The RESET command on a channel is meant to return a channel to
ALLOCATED state after it's been stopped.  But if it was never
started, its state will still be ALLOCATED, the RESET command
is not required.

Quietly skip doing the reset without printing an error message if a
channel is already in ALLOCATED state when we request it be reset.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent f8d3bdd5

drivers/net/ipa/gsi.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -576,6 +576,8 @@ static void gsi_channel_reset_command(struct gsi_channel *channel)
		state = gsi_channel_state(channel);
		if (state != GSI_CHANNEL_STATE_STOPPED &&
		state != GSI_CHANNEL_STATE_ERROR) {
		/* No need to reset a channel already in ALLOCATED state */
		if (state != GSI_CHANNEL_STATE_ALLOCATED)
		dev_err(dev, "channel %u bad state %u before reset\n",
		gsi_channel_id(channel), state);
		return;

Admin message