Commit 5d27aa5a authored Nov 06, 2012 by Arnd Bergmann Committed by Artem Bityutskiy Nov 16, 2012

mtd: uninitialized variable warning in map.h

The map_word_load() function initializes exactly
as many words in the buffer as required, but gcc
cannot figure this out and gives a misleading
warning. Marking the local variable as
uninitialized_var shuts up that warning.

Without this patch, building acs5k_defconfig results in:

drivers/mtd/chips/cfi_cmdset_0002.c: In function 'cfi_amdstd_panic_write':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wuninitialized]
drivers/mtd/chips/cfi_cmdset_0002.c: In function 'cfi_amdstd_write_words':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wuninitialized]
drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

parent d611d41b

include/linux/mtd/map.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -391,7 +391,7 @@ static inline map_word map_word_ff(struct map_info *map)

		static inline map_word inline_map_read(struct map_info *map, unsigned long ofs)
		{
		map_word r;
		map_word uninitialized_var(r);

		if (map_bankwidth_is_1(map))
		r.x[0] = __raw_readb(map->virt + ofs);

Admin message