hwmon: (iio_hwmon) fix memory leak in name attribute (5d17d3b4) · Commits · 戴 / test

The "name" variable's memory is now freed when the device is destructed thanks to devm function. Signed-off-by:

Quentin Schulz <quentin.schulz@free-electrons.com> Reported-by:

Guenter Roeck <linux@roeck-us.net> Fixes: ("staging:iio::hwmon interface client driver.") Fixes: ("hwmon: (iio_hwmon) Add support for humidity sensors") Signed-off-by:

Guenter Roeck <linux@roeck-us.net>

drivers/hwmon/iio_hwmon.c

+12 −12

Original line number	Diff line number	Diff line
		@@ -110,22 +110,22 @@ static int iio_hwmon_probe(struct platform_device *pdev)

		switch (type) {
		case IIO_VOLTAGE:
		a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
		a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
		"in%d_input",
		in_i++);
		break;
		case IIO_TEMP:
		a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
		a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
		"temp%d_input",
		temp_i++);
		break;
		case IIO_CURRENT:
		a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
		a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
		"curr%d_input",
		curr_i++);
		break;
		case IIO_HUMIDITYRELATIVE:
		a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
		a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
		"humidity%d_input",
		humidity_i++);
		break;

Admin message