Commit 5d124e99 authored Oct 02, 2006 by Pavel Committed by Linus Torvalds Oct 02, 2006

[PATCH] nsproxy cloning error path fix



This patch fixes copy_namespaces()'s error path.

when new nsproxy (new_ns) is created pointers to namespaces (ipc, uts) are
copied from the old nsproxy.  Later in copy_utsname, copy_ipcs, etc.
according namespaces are get-ed.  On error path needed namespaces are
put-ed, so there's no need to put new nsproxy itelf as it woud cause
putting namespaces for the second time.

Found when incorporating namespaces into OpenVZ kernel.

Signed-off-by: Pavel Emelianov <xemul@openvz.org>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent fcfbd547

kernel/nsproxy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -123,7 +123,7 @@ out_uts:
		put_namespace(new_ns->namespace);
		out_ns:
		tsk->nsproxy = old_ns;
		put_nsproxy(new_ns);
		kfree(new_ns);
		goto out;
		}

Admin message