Commit 5d05e815 authored Apr 19, 2017 by Arnd Bergmann Committed by Alexandre Belloni Apr 22, 2017

rtc: sh: mark PM functions as unused

The sh_rtc_set_irq_wake() function is only called from the suspend/resume handlers
that may be hidden, causing a harmless warning:

drivers/rtc/rtc-sh.c:724:13: error: 'sh_rtc_set_irq_wake' defined but not used [-Werror=unused-function]
static void sh_rtc_set_irq_wake(struct device *dev, int enabled)

The most reliable way to avoid the warning is to remove the existing #ifdef
and mark the two functions as __maybe_unused so the compiler can silently
drop all three when there is no reference.

Fixes: dab5aec6 ("rtc: sh: add support for rza series")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent e73ef755

drivers/rtc/rtc-sh.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -734,8 +734,7 @@ static void sh_rtc_set_irq_wake(struct device *dev, int enabled)
		}
		}

		#ifdef CONFIG_PM_SLEEP
		static int sh_rtc_suspend(struct device *dev)
		static int __maybe_unused sh_rtc_suspend(struct device *dev)
		{
		if (device_may_wakeup(dev))
		sh_rtc_set_irq_wake(dev, 1);
		@@ -743,14 +742,13 @@ static int sh_rtc_suspend(struct device *dev)
		return 0;
		}

		static int sh_rtc_resume(struct device *dev)
		static int __maybe_unused sh_rtc_resume(struct device *dev)
		{
		if (device_may_wakeup(dev))
		sh_rtc_set_irq_wake(dev, 0);

		return 0;
		}
		#endif

		static SIMPLE_DEV_PM_OPS(sh_rtc_pm_ops, sh_rtc_suspend, sh_rtc_resume);

Admin message