Commit 5cf81ce1 authored by Dan Williams's avatar Dan Williams Committed by Vishal Verma
Browse files

libnvdimm: Convert to DEVICE_ATTR_ADMIN_RO() 



Move libnvdimm sysfs attributes that currently use an open coded
DEVICE_ATTR() to hide sensitive root-only information (physical memory
layout) to the new DEVICE_ATTR_ADMIN_RO() helper.

Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarVishal Verma <vishal.l.verma@intel.com>
parent 60d360ac

drivers/nvdimm/namespace_devs.c

+1 −1
Original line number Diff line number Diff line
@@ -1309,7 +1309,7 @@ static ssize_t resource_show(struct device *dev, 
		return -ENXIO;

	return sprintf(buf, "%#llx\n", (unsigned long long) res->start);

}

static DEVICE_ATTR(resource, 0400, resource_show, NULL);

static DEVICE_ATTR_ADMIN_RO(resource);



static const unsigned long blk_lbasize_supported[] = { 512, 520, 528,

	4096, 4104, 4160, 4224, 0 };

drivers/nvdimm/pfn_devs.c

+1 −1
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static ssize_t resource_show(struct device *dev, 


	return rc;

}

static DEVICE_ATTR(resource, 0400, resource_show, NULL);

static DEVICE_ATTR_ADMIN_RO(resource);



static ssize_t size_show(struct device *dev,

		struct device_attribute *attr, char *buf)

drivers/nvdimm/region_devs.c

+1 −1
Original line number Diff line number Diff line
@@ -605,7 +605,7 @@ static ssize_t resource_show(struct device *dev, 


	return sprintf(buf, "%#llx\n", nd_region->ndr_start);

}

static DEVICE_ATTR(resource, 0400, resource_show, NULL);

static DEVICE_ATTR_ADMIN_RO(resource);



static ssize_t persistence_domain_show(struct device *dev,

		struct device_attribute *attr, char *buf)

CRA Git | Maintained and supported by SUSTech CRA and CCSE