Commit 5cf3006c authored Jul 08, 2018 by Bernd Edlinger Committed by Johannes Berg Jul 09, 2018

nl80211: Add a missing break in parse_station_flags



I was looking at usually suppressed gcc warnings,
[-Wimplicit-fallthrough=] in this case:

The code definitely looks like a break is missing here.
However I am not able to test the NL80211_IFTYPE_MESH_POINT,
nor do I actually know what might be :)
So please use this patch with caution and only if you are
able to do some testing.

Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
[johannes: looks obvious enough to apply as is, interesting
 though that it never seems to have been a problem]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent a948f713

net/wireless/nl80211.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -4409,6 +4409,7 @@ static int parse_station_flags(struct genl_info *info,
		params->sta_flags_mask = BIT(NL80211_STA_FLAG_AUTHENTICATED) \|
		BIT(NL80211_STA_FLAG_MFP) \|
		BIT(NL80211_STA_FLAG_AUTHORIZED);
		break;
		default:
		return -EINVAL;
		}

Admin message