Commit 5cf02612 authored Jun 16, 2019 by Xin Long Committed by David S. Miller Jun 16, 2019

tipc: purge deferredq list for each grp member in tipc_group_delete



Syzbot reported a memleak caused by grp members' deferredq list not
purged when the grp is be deleted.

The issue occurs when more(msg_grp_bc_seqno(hdr), m->bc_rcv_nxt) in
tipc_group_filter_msg() and the skb will stay in deferredq.

So fix it by calling __skb_queue_purge for each member's deferredq
in tipc_group_delete() when a tipc sk leaves the grp.

Fixes: b87a5ea3 ("tipc: guarantee group unicast doesn't bypass group broadcast")
Reported-by:  <syzbot+78fbe679c8ca8d264a8d@syzkaller.appspotmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d4d5d8e8

net/tipc/group.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -218,6 +218,7 @@ void tipc_group_delete(struct net net, struct tipc_group grp)

		rbtree_postorder_for_each_entry_safe(m, tmp, tree, tree_node) {
		tipc_group_proto_xmit(grp, m, GRP_LEAVE_MSG, &xmitq);
		__skb_queue_purge(&m->deferredq);
		list_del(&m->list);
		kfree(m);
		}

Admin message