Commit 5ceb1a04 authored Nov 02, 2008 by Matt Fleming Committed by Thomas Gleixner Nov 10, 2008

x86: HPET: enter hpet_interrupt_handler with interrupts disabled

Some functions that may be called from this handler require that
interrupts are disabled. Also, combining IRQF_DISABLED and
IRQF_SHARED does not reliably disable interrupts in a handler, so
remove IRQF_SHARED from the irq flags (this irq is not shared anyway).

Signed-off-by: Matt Fleming <mjf@gentoo.org>
Cc: mingo@elte.hu
Cc: venkatesh.pallipadi@intel.com
Cc: "Will Newton" <will.newton@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 89d77a1e

arch/x86/kernel/hpet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -445,7 +445,7 @@ static int hpet_setup_irq(struct hpet_dev *dev)
		{

		if (request_irq(dev->irq, hpet_interrupt_handler,
		IRQF_SHARED\|IRQF_NOBALANCING, dev->name, dev))
		IRQF_DISABLED\|IRQF_NOBALANCING, dev->name, dev))
		return -1;

		disable_irq(dev->irq);

Admin message