Commit 5ce8aee8 authored May 27, 2020 by Tony Lindgren

bus: ti-sysc: Flush posted write on enable and disable



Looks like we're missing flush of posted write after module enable and
disable. I've seen occasional errors accessing various modules, and it
is suspected that the lack of posted writes can also cause random reboots.

The errors we can see are similar to the one below from spi for example:

44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4CFG (Read): Data Access
in User mode during Functional access
...
mcspi_wait_for_reg_bit
omap2_mcspi_transfer_one
spi_transfer_one_message
...

We also want to also flush posted write for disable. The clkctrl clock
disable happens after module disable, and we don't want to have the
module potentially stay active while we're trying to disable the clock.

Fixes: d59b6056 ("bus: ti-sysc: Add generic enable/disable functions")
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 98ece19f

drivers/bus/ti-sysc.c

+6 −0

Original line number	Original line	Diff line number	Diff line
	@@ -991,6 +991,9 @@ set_autoidle:
	sysc_write_sysconfig(ddata, reg);		sysc_write_sysconfig(ddata, reg);
	}		}

			/* Flush posted write */
			sysc_read(ddata, ddata->offsets[SYSC_SYSCONFIG]);

	if (ddata->module_enable_quirk)		if (ddata->module_enable_quirk)
	ddata->module_enable_quirk(ddata);		ddata->module_enable_quirk(ddata);

	@@ -1071,6 +1074,9 @@ set_sidle:
	reg \|= 1 << regbits->autoidle_shift;		reg \|= 1 << regbits->autoidle_shift;
	sysc_write_sysconfig(ddata, reg);		sysc_write_sysconfig(ddata, reg);

			/* Flush posted write */
			sysc_read(ddata, ddata->offsets[SYSC_SYSCONFIG]);

	return 0;		return 0;
	}		}

Admin message