Commit 5ce524bd authored Oct 01, 2010 by Hans de Goede Committed by Greg Kroah-Hartman Oct 22, 2010

scsi/sd: add a no_read_capacity_16 scsi_device flag



I seem to have a knack for digging up buggy usb devices which don't work
with Linux, and I'm crazy enough to try to make them work.  So this time a
friend of mine asked me to get an mp4 player (an mp3 player which can play
videos on a small screen) to work with Linux.

It is based on the well known rockbox chipset for which we already have an
unusual devs entries to work around some of its bugs.  But this model
comes with an additional twist.

This model chokes on read_capacity_16 calls.  Now normally we don't make
those calls, but this model comes with an sdcard slot and when there is no
card in there (and shipped from the factory there is none), it reports a
size of 0.  However this time the programmers actually got the
read_capacity_10 response right!  So they substract one from the size as
stored internally in the mp3 player before reporting it back, resulting in
an answer of ...  0xffffffff sectors, causing sd.c to try a
read_capacity_16, on which the device crashes.

This patch adds a flag to scsi_device to indicate that a a device cannot
handle read_capacity_16, and when this flag is set if a device reports an
lba of 0xffffffff as answer to a read_capacity_10, assumes it tries to
report a size of 0.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent ae38c78a

drivers/scsi/sd.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -1498,6 +1498,9 @@ static int read_capacity_16(struct scsi_disk sdkp, struct scsi_device sdp,
		unsigned long long lba;
		unsigned sector_size;

		if (sdp->no_read_capacity_16)
		return -EINVAL;

		do {
		memset(cmd, 0, 16);
		cmd[0] = SERVICE_ACTION_IN;
		@@ -1626,6 +1629,15 @@ static int read_capacity_10(struct scsi_disk sdkp, struct scsi_device sdp,
		sector_size = get_unaligned_be32(&buffer[4]);
		lba = get_unaligned_be32(&buffer[0]);

		if (sdp->no_read_capacity_16 && (lba == 0xffffffff)) {
		/* Some buggy (usb cardreader) devices return an lba of
		0xffffffff when the want to report a size of 0 (with
		which they really mean no media is present) */
		sdkp->capacity = 0;
		sdkp->hw_sector_size = sector_size;
		return sector_size;
		}

		if ((sizeof(sdkp->capacity) == 4) && (lba == 0xffffffff)) {
		sd_printk(KERN_ERR, sdkp, "Too big for this kernel. Use a "
		"kernel compiled with support for large block "

include/scsi/scsi_device.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -149,6 +149,7 @@ struct scsi_device {
		unsigned last_sector_bug:1; /* do not use multisector accesses on
		SD_LAST_BUGGY_SECTORS */
		unsigned no_read_disc_info:1; /* Avoid READ_DISC_INFO cmds */
		unsigned no_read_capacity_16:1; /* Avoid READ_CAPACITY_16 cmds */
		unsigned is_visible:1; /* is the device visible in sysfs */

		DECLARE_BITMAP(supported_events, SDEV_EVT_MAXBITS); /* supported events */

Admin message