Commit 5cc6b16e authored Apr 20, 2019 by Borislav Petkov

RAS/CEC: Do not set decay value on error



When the value requested doesn't match the allowed (min,max) range,
the @data buffer should not be modified with the invalid value because
reading "decay_interval" shows it otherwise as if the previous write
succeeded.

Move the data write after the check.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>

parent de0e0624

drivers/ras/cec.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -371,17 +371,17 @@ DEFINE_DEBUGFS_ATTRIBUTE(pfn_ops, u64_get, pfn_set, "0x%llx\n");

		static int decay_interval_set(void *data, u64 val)
		{
		(u64 )data = val;

		if (val < CEC_DECAY_MIN_INTERVAL)
		return -EINVAL;

		if (val > CEC_DECAY_MAX_INTERVAL)
		return -EINVAL;

		(u64 )data = val;
		decay_interval = val;

		cec_mod_work(decay_interval);

		return 0;
		}
		DEFINE_DEBUGFS_ATTRIBUTE(decay_interval_ops, u64_get, decay_interval_set, "%lld\n");

Admin message