Commit 5cc59f59 authored Sep 08, 2019 by Joao Martins Committed by Rafael J. Wysocki Sep 11, 2019

cpuidle-haltpoll: return -ENODEV on modinit failure



When a user loads cpuidle-haltpoll on a non KVM guest the module will
successfully load, even though idle driver registration didn't take
place.

We should instead return -ENODEV signaling the user that the driver can't
be loaded, like other error paths in haltpoll_init().  An example of such
error paths is when we return -EBUSY when attempting to register an idle
driver when it had one already (e.g. intel_idle loads at boot and then we
attempt to insert module cpuidle-haltpoll).

Fixes: fa86ee90 ("add cpuidle-haltpoll driver")
Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 73214408

drivers/cpuidle/cpuidle-haltpoll.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,7 @@ static int __init haltpoll_init(void)
		cpuidle_poll_state_init(drv);

		if (!kvm_para_available())
		return 0;
		return -ENODEV;

		ret = cpuidle_register_driver(drv);
		if (ret < 0)

Admin message