Commit 5ca7d1ca authored Jan 05, 2017 by Grygorii Strashko Committed by David S. Miller Jan 06, 2017

net: phy: dp83867: fix irq generation

For proper IRQ generation by DP83867 phy the INT/PWDN pin has to be
programmed as an interrupt output instead of a Powerdown input in
Configuration Register 3 (CFG3), Address 0x001E, bit 7 INT_OE = 1. The
current driver doesn't do this and as result IRQs will not be generated by
DP83867 phy even if they are properly configured in DT.

Hence, fix IRQ generation by properly configuring CFG3.INT_OE bit and
ensure that Link Status Change (LINK_STATUS_CHNG_INT) and Auto-Negotiation
Complete (AUTONEG_COMP_INT) interrupt are enabled. After this the DP83867
driver will work properly in interrupt enabled mode.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 896b4db6

drivers/net/phy/dp83867.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -29,6 +29,7 @@
		#define MII_DP83867_MICR 0x12
		#define MII_DP83867_ISR 0x13
		#define DP83867_CTRL 0x1f
		#define DP83867_CFG3 0x1e

		/* Extended Registers */
		#define DP83867_RGMIICTL 0x0032
		@@ -98,6 +99,8 @@ static int dp83867_config_intr(struct phy_device *phydev)
		micr_status \|=
		(MII_DP83867_MICR_AN_ERR_INT_EN \|
		MII_DP83867_MICR_SPEED_CHNG_INT_EN \|
		MII_DP83867_MICR_AUTONEG_COMP_INT_EN \|
		MII_DP83867_MICR_LINK_STS_CHNG_INT_EN \|
		MII_DP83867_MICR_DUP_MODE_CHNG_INT_EN \|
		MII_DP83867_MICR_SLEEP_MODE_CHNG_INT_EN);

		@@ -214,6 +217,13 @@ static int dp83867_config_init(struct phy_device *phydev)
		}
		}

		/* Enable Interrupt output INT_OE in CFG3 register */
		if (phy_interrupt_is_valid(phydev)) {
		val = phy_read(phydev, DP83867_CFG3);
		val \|= BIT(7);
		phy_write(phydev, DP83867_CFG3, val);
		}

		return 0;
		}

Admin message