Commit 5ca7c109 authored by Jon Hunter's avatar Jon Hunter Committed by Vinod Koul
Browse files

of: dma: fix potential deadlock when requesting a slave channel 



In the latest version of the OF dma handlers I added support (rather hastily)
to exhaustively search for an available dma slave channel, for the use-case
where we have alternative slave channels that can be used. In the current
implementation a deadlock scenario can occur causing the CPU to loop forever.
The scenario is as follows ...

1. There are alternative channels avaialble
2. The first channel that is found by calling of_dma_find_channel() is not
   available and so the call to the xlate function returns NULL. In this case
   we will call of_dma_find_channel() again but we will return the same channel
   that we found the first time and hence, again the xlate will return NULL and
   we will loop here forever.

Fix this potential deadlock by just using a single for-loop and not a for-loop
nested in a do-while loop. This change also replaces the function
of_dma_find_channel() with of_dma_match_channel() which performs a simple check
to see if a DMA channel matches the name specified.

I have tested this implementation on an OMAP4 panda board by adding a dummy
DMA specifier, that will cause the xlate function to return NULL, to the
beginning of a list of DMA specifiers for a DMA client.

Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Stephen Warren <swarren@nvidia.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <djbw@fb.com>

Signed-off-by: default avatarJon Hunter <jon-hunter@ti.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@linux.intel.com>
parent bfc191ea

drivers/of/dma.c

+30 −30
Original line number Diff line number Diff line
@@ -108,37 +108,32 @@ void of_dma_controller_free(struct device_node *np) 
EXPORT_SYMBOL_GPL(of_dma_controller_free);



/**

 * of_dma_find_channel - Find a DMA channel by name

 * of_dma_match_channel - Check if a DMA specifier matches name

 * @np:		device node to look for DMA channels

 * @name:	name of desired channel

 * @name:	channel name to be matched

 * @index:	index of DMA specifier in list of DMA specifiers

 * @dma_spec:	pointer to DMA specifier as found in the device tree

 *

 * Find a DMA channel by the name. Returns 0 on success or appropriate

 * errno value on error.

 * Check if the DMA specifier pointed to by the index in a list of DMA

 * specifiers, matches the name provided. Returns 0 if the name matches and

 * a valid pointer to the DMA specifier is found. Otherwise returns -ENODEV.

 */

static int of_dma_find_channel(struct device_node *np, char *name,

static int of_dma_match_channel(struct device_node *np, char *name, int index,

				struct of_phandle_args *dma_spec)

{

	int count, i;

	const char *s;



	count = of_property_count_strings(np, "dma-names");

	if (count < 0)

		return count;



	for (i = 0; i < count; i++) {

		if (of_property_read_string_index(np, "dma-names", i, &s))

			continue;

	if (of_property_read_string_index(np, "dma-names", index, &s))

		return -ENODEV;



	if (strcmp(name, s))

			continue;

		return -ENODEV;



		if (!of_parse_phandle_with_args(np, "dmas", "#dma-cells", i,

	if (of_parse_phandle_with_args(np, "dmas", "#dma-cells", index,

				       dma_spec))

			return 0;

	}



		return -ENODEV;



	return 0;

}



/**
@@ -154,20 +149,23 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np, 
	struct of_phandle_args	dma_spec;

	struct of_dma		*ofdma;

	struct dma_chan		*chan;

	int			r;

	int			count, i;



	if (!np || !name) {

		pr_err("%s: not enough information provided\n", __func__);

		return NULL;

	}



	do {

		r = of_dma_find_channel(np, name, &dma_spec);

		if (r) {

			pr_err("%s: can't find DMA channel\n", np->full_name);

	count = of_property_count_strings(np, "dma-names");

	if (count < 0) {

		pr_err("%s: dma-names property missing or empty\n", __func__);

		return NULL;

	}



	for (i = 0; i < count; i++) {

		if (of_dma_match_channel(np, name, i, &dma_spec))

			continue;



		ofdma = of_dma_find_controller(dma_spec.np);

		if (!ofdma) {

			pr_debug("%s: can't find DMA controller %s\n",
@@ -185,11 +183,13 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np, 


		of_node_put(dma_spec.np);



	} while (!chan);



		if (chan)

			return chan;

	}



	return NULL;

}



/**

 * of_dma_simple_xlate - Simple DMA engine translation function

 * @dma_spec:	pointer to DMA specifier as found in the device tree

CRA Git | Maintained and supported by SUSTech CRA and CCSE