Commit 5c989a0e authored Dec 10, 2017 by Darrick J. Wong

xfs: remove dest file's post-eof preallocations before reflinking

If we try to reflink into a file with post-eof preallocations at an
offset well past the preallocations, we increase i_size as one would
expect. However, those allocations do not have page cache backing them,
so they won't get cleaned out on their own. This leads to asserts in
the collapse/insert range code and xfs_destroy_inode when they encounter
delalloc extents they weren't expecting to find.

Since there are plenty of other places where we dump those post-eof
blocks, do the same to the reflink destination file before we start
remapping extents. This was found by adding clonerange support to
fsstress and running it in write-only mode.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent c54854a4

fs/xfs/xfs_reflink.c

+11 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1291,6 +1291,17 @@ xfs_reflink_remap_range(

	trace_xfs_reflink_remap_range(src, pos_in, len, dest, pos_out);		trace_xfs_reflink_remap_range(src, pos_in, len, dest, pos_out);

			/*
			* Clear out post-eof preallocations because we don't have page cache
			* backing the delayed allocations and they'll never get freed on
			* their own.
			*/
			if (xfs_can_free_eofblocks(dest, true)) {
			ret = xfs_free_eofblocks(dest);
			if (ret)
			goto out_unlock;
			}

	/* Set flags and remap blocks. */		/* Set flags and remap blocks. */
	ret = xfs_reflink_set_inode_flag(src, dest);		ret = xfs_reflink_set_inode_flag(src, dest);
	if (ret)		if (ret)

Admin message