net: hns3: remove unnecessary frag list checking in hns3_nic_net_xmit() (5c6cfd30) · Commits · 戴 / test

The skb_has_frag_list() in hns3_nic_net_xmit() is redundant, since skb_walk_frags() includes this checking implicitly. Reported-by:

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1445,9 +1445,6 @@ netdev_tx_t hns3_nic_net_xmit(struct sk_buff skb, struct net_device netdev)

		bd_num += ret;

		if (!skb_has_frag_list(skb))
		goto out;

		skb_walk_frags(skb, frag_skb) {
		ret = hns3_fill_skb_to_desc(ring, frag_skb,
		DESC_TYPE_FRAGLIST_SKB);
		@@ -1456,7 +1453,7 @@ netdev_tx_t hns3_nic_net_xmit(struct sk_buff skb, struct net_device netdev)

		bd_num += ret;
		}
		out:

		pre_ntu = ring->next_to_use ? (ring->next_to_use - 1) :
		(ring->desc_num - 1);
		ring->desc[pre_ntu].tx.bdtp_fe_sc_vld_ra_ri \|=