Commit 5c5fd819 authored Jun 01, 2012 by Artem Bityutskiy Committed by Al Viro Jun 01, 2012

reiserfs: mark the superblock as dirty a bit later



The 'journal_mark_dirty()' function currently first marks the superblock as
dirty by setting 's_dirt' to 1, then does various sanity checks and returns,
then actuall does all the magic with the journal.

This is not an ideal order, though. It makes more sense to first do all the
checks, then do all the internal stuff, and at the end notify the VFS that the
superblock is now dirty.

This patch moves the 's_dirt = 1' assignment from the very beginning of this
function to the very end.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 717f03c4

fs/reiserfs/journal.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -3231,8 +3231,6 @@ int journal_mark_dirty(struct reiserfs_transaction_handle *th,
		th->t_trans_id, journal->j_trans_id);
		}

		sb->s_dirt = 1;

		prepared = test_clear_buffer_journal_prepared(bh);
		clear_buffer_journal_restore_dirty(bh);
		/* already in this transaction, we are done */
		@@ -3316,6 +3314,7 @@ int journal_mark_dirty(struct reiserfs_transaction_handle *th,
		journal->j_first = cn;
		journal->j_last = cn;
		}
		sb->s_dirt = 1;
		return 0;
		}

Admin message