Commit 5c487bb9 authored Feb 06, 2018 by Song Liu Committed by David S. Miller Feb 07, 2018

tcp: tracepoint: only call trace_tcp_send_reset with full socket



tracepoint tcp_send_reset requires a full socket to work. However, it
may be called when in TCP_TIME_WAIT:

        case TCP_TW_RST:
                tcp_v6_send_reset(sk, skb);
                inet_twsk_deschedule_put(inet_twsk(sk));
                goto discard_it;

To avoid this problem, this patch checks the socket with sk_fullsock()
before calling trace_tcp_send_reset().

Fixes: c24b14c4 ("tcp: add tracepoint trace_tcp_send_reset")
Signed-off-by: Song Liu <songliubraving@fb.com>
Reviewed-by: Lawrence Brakmo <brakmo@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 043e337f

net/ipv4/tcp_ipv4.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -705,6 +705,7 @@ static void tcp_v4_send_reset(const struct sock sk, struct sk_buff skb)
		*/
		if (sk) {
		arg.bound_dev_if = sk->sk_bound_dev_if;
		if (sk_fullsock(sk))
		trace_tcp_send_reset(sk, skb);
		}

net/ipv6/tcp_ipv6.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -942,6 +942,7 @@ static void tcp_v6_send_reset(const struct sock sk, struct sk_buff skb)

		if (sk) {
		oif = sk->sk_bound_dev_if;
		if (sk_fullsock(sk))
		trace_tcp_send_reset(sk, skb);
		}

Admin message