Commit 5c3ceef9 authored Aug 02, 2019 by Qais Yousef Committed by Peter Zijlstra Aug 08, 2019

cpufreq: schedutil: fix equation in comment



scale_irq_capacity() call in schedutil_cpu_util() does

	util *= (max - irq)
	util /= max

But the comment says

	util *= (1 - irq)
	util /= max

Fix the comment to match what the scaling function does.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>
Link: https://lkml.kernel.org/r/20190802104628.8410-1-qais.yousef@arm.com

parent 67692435

kernel/sched/cpufreq_schedutil.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -259,8 +259,8 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs,
		* irq metric. Because IRQ/steal time is hidden from the task clock we
		* need to scale the task numbers:
		*
		* 1 - irq
		* U' = irq + ------- * U
		* max - irq
		* U' = irq + --------- * U
		* max
		*/
		util = scale_irq_capacity(util, irq, max);

Admin message