Commit 5c27de1d authored May 24, 2019 by Hans de Goede

drm/i915/dsi: Call drm_connector_cleanup on vlv_dsi_init error exit path

If we exit vlv_dsi_init() because we failed to find a fixed_mode, then
we've already called drm_connector_init() and we should call
drm_connector_cleanup() to unregister the connector object.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190524163518.17545-1-hdegoede@redhat.com

parent c0a74c73

drivers/gpu/drm/i915/vlv_dsi.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1793,7 +1793,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)

		if (!fixed_mode) {
		DRM_DEBUG_KMS("no fixed mode\n");
		goto err;
		goto err_cleanup_connector;
		}

		intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
		@@ -1803,6 +1803,8 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)

		return;

		err_cleanup_connector:
		drm_connector_cleanup(&intel_connector->base);
		err:
		drm_encoder_cleanup(&intel_encoder->base);
		kfree(intel_dsi);