Commit 5c1baaa8 authored Aug 18, 2019 by Wenwen Wang Committed by Doug Ledford Aug 20, 2019

IB/mlx4: Fix memory leaks



In mlx4_ib_alloc_pv_bufs(), 'tun_qp->tx_ring' is allocated through
kcalloc(). However, it is not always deallocated in the following execution
if an error occurs, leading to memory leaks. To fix this issue, free
'tun_qp->tx_ring' whenever an error occurs.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Link: https://lore.kernel.org/r/1566159781-4642-1-git-send-email-wenwen@cs.uga.edu


Signed-off-by: Doug Ledford <dledford@redhat.com>

parent a7bfb93f

drivers/infiniband/hw/mlx4/mad.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1677,8 +1677,6 @@ tx_err:
		tx_buf_size, DMA_TO_DEVICE);
		kfree(tun_qp->tx_ring[i].buf.addr);
		}
		kfree(tun_qp->tx_ring);
		tun_qp->tx_ring = NULL;
		i = MLX4_NUM_TUNNEL_BUFS;
		err:
		while (i > 0) {
		@@ -1687,6 +1685,8 @@ err:
		rx_buf_size, DMA_FROM_DEVICE);
		kfree(tun_qp->ring[i].addr);
		}
		kfree(tun_qp->tx_ring);
		tun_qp->tx_ring = NULL;
		kfree(tun_qp->ring);
		tun_qp->ring = NULL;
		return -ENOMEM;

Admin message