Commit 5bf33f04 authored Dec 30, 2019 by Mateusz Nosek Committed by Greg Kroah-Hartman Jan 14, 2020

fs/kernfs/dir.c: Clean code by removing always true condition



Previously there was an additional check if variable pos is not null.
However, this check happens after entering while loop and only then,
which can happen only if pos is not null.
Therefore the additional check is redundant and can be removed.

Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20191230191628.21099-1-mateusznosek0@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ef9ffc1e

fs/kernfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1266,7 +1266,7 @@ void kernfs_activate(struct kernfs_node *kn)

		pos = NULL;
		while ((pos = kernfs_next_descendant_post(pos, kn))) {
		if (!pos \|\| (pos->flags & KERNFS_ACTIVATED))
		if (pos->flags & KERNFS_ACTIVATED)
		continue;

		WARN_ON_ONCE(pos->parent && RB_EMPTY_NODE(&pos->rb));

Admin message