Commit 5bf2fc1f authored Dec 19, 2019 by Aditya Pakki Committed by Daniel Borkmann Dec 19, 2019

bpf: Remove unnecessary assertion on fp_old



The two callers of bpf_prog_realloc - bpf_patch_insn_single and
bpf_migrate_filter dereference the struct fp_old, before passing
it to the function. Thus assertion to check fp_old is unnecessary
and can be removed.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20191219175735.19231-1-pakki001@umn.edu

parent 7745ff98

kernel/bpf/core.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -222,8 +222,6 @@ struct bpf_prog bpf_prog_realloc(struct bpf_prog fp_old, unsigned int size,
		u32 pages, delta;
		int ret;

		BUG_ON(fp_old == NULL);

		size = round_up(size, PAGE_SIZE);
		pages = size / PAGE_SIZE;
		if (pages <= fp_old->pages)

Admin message