Commit 5bdc7380 authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller
Browse files

mii: Handle link state changes for forced modes in mii_check_media() 



mii_check_media() does not update the link (carrier) state or log link
changes when the link mode is forced.  Drivers using the mii library
must do this themselves, but most of them do not.

Instead of changing them all, provide a sensible default behaviour
similar to mii_check_link() when the mode is forced.

via-rhine depends on it being a no-op in this case, so make its call
to mii_check_media() conditional.

Signed-off-by: default avatarBen Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8f1115b4

drivers/net/ethernet/amd/pcnet32.c

+1 −1
Original line number Diff line number Diff line
@@ -2806,7 +2806,7 @@ static void pcnet32_check_media(struct net_device *dev, int verbose) 


/*

 * Check for loss of link and link establishment.

 * Can not use mii_check_media because it does nothing if mode is forced.

 * Could possibly be changed to use mii_check_media instead.

 */



static void pcnet32_watchdog(struct net_device *dev)

drivers/net/ethernet/via/via-rhine.c

+2 −1
Original line number Diff line number Diff line
@@ -1326,6 +1326,7 @@ static void rhine_check_media(struct net_device *dev, unsigned int init_media) 
	struct rhine_private *rp = netdev_priv(dev);

	void __iomem *ioaddr = rp->base;



	if (!rp->mii_if.force_media)

		mii_check_media(&rp->mii_if, netif_msg_link(rp), init_media);



	if (rp->mii_if.full_duplex)

drivers/net/mii.c

+7 −5
Original line number Diff line number Diff line
@@ -302,7 +302,7 @@ void mii_check_link (struct mii_if_info *mii) 
}



/**

 * mii_check_media - check the MII interface for a duplex change

 * mii_check_media - check the MII interface for a carrier/speed/duplex change

 * @mii: the MII interface

 * @ok_to_print: OK to print link up/down messages

 * @init_media: OK to save duplex mode in @mii
@@ -318,10 +318,6 @@ unsigned int mii_check_media (struct mii_if_info *mii, 
	int advertise, lpa, media, duplex;

	int lpa2 = 0;



	/* if forced media, go no further */

	if (mii->force_media)

		return 0; /* duplex did not change */



	/* check current and old link status */

	old_carrier = netif_carrier_ok(mii->dev) ? 1 : 0;

	new_carrier = (unsigned int) mii_link_ok(mii);
@@ -345,6 +341,12 @@ unsigned int mii_check_media (struct mii_if_info *mii, 
	 */

	netif_carrier_on(mii->dev);



	if (mii->force_media) {

		if (ok_to_print)

			netdev_info(mii->dev, "link up\n");

		return 0; /* duplex did not change */

	}



	/* get MII advertise and LPA values */

	if ((!init_media) && (mii->advertising))

		advertise = mii->advertising;

CRA Git | Maintained and supported by SUSTech CRA and CCSE