Commit 5bcbe0f3 authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

phy: fixed: Fix removal of phys. 



The fixed phys delete function simply removed the fixed phy from the
internal linked list and freed the memory. It however did not
unregister the associated phy device. This meant it was still possible
to find the phy device on the mdio bus.

Make fixed_phy_del() an internal function and add a
fixed_phy_unregister() to unregisters the phy device and then uses
fixed_phy_del() to free resources.

Modify DSA to use this new API function, so we don't leak phys.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ec777e6b

drivers/net/phy/fixed_phy.c

+9 −2
Original line number Diff line number Diff line
@@ -285,7 +285,7 @@ err_regs: 
}

EXPORT_SYMBOL_GPL(fixed_phy_add);



void fixed_phy_del(int phy_addr)

static void fixed_phy_del(int phy_addr)

{

	struct fixed_mdio_bus *fmb = &platform_fmb;

	struct fixed_phy *fp, *tmp;
@@ -300,7 +300,6 @@ void fixed_phy_del(int phy_addr) 
		}

	}

}

EXPORT_SYMBOL_GPL(fixed_phy_del);



static int phy_fixed_addr;

static DEFINE_SPINLOCK(phy_fixed_addr_lock);
@@ -371,6 +370,14 @@ struct phy_device *fixed_phy_register(unsigned int irq, 
}

EXPORT_SYMBOL_GPL(fixed_phy_register);



void fixed_phy_unregister(struct phy_device *phy)

{

	phy_device_remove(phy);



	fixed_phy_del(phy->mdio.addr);

}

EXPORT_SYMBOL_GPL(fixed_phy_unregister);



static int __init fixed_mdio_bus_init(void)

{

	struct fixed_mdio_bus *fmb = &platform_fmb;

include/linux/phy_fixed.h

+2 −3
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ extern struct phy_device *fixed_phy_register(unsigned int irq, 
					     struct fixed_phy_status *status,

					     int link_gpio,

					     struct device_node *np);

extern void fixed_phy_del(int phy_addr);

extern void fixed_phy_unregister(struct phy_device *phydev);

extern int fixed_phy_set_link_update(struct phy_device *phydev,

			int (*link_update)(struct net_device *,

					   struct fixed_phy_status *));
@@ -40,9 +40,8 @@ static inline struct phy_device *fixed_phy_register(unsigned int irq, 
{

	return ERR_PTR(-ENODEV);

}

static inline int fixed_phy_del(int phy_addr)

static inline void fixed_phy_unregister(struct phy_device *phydev)

{

	return -ENODEV;

}

static inline int fixed_phy_set_link_update(struct phy_device *phydev,

			int (*link_update)(struct net_device *,

net/dsa/dsa.c

+1 −3
Original line number Diff line number Diff line
@@ -447,11 +447,9 @@ static void dsa_switch_destroy(struct dsa_switch *ds) 
		if (of_phy_is_fixed_link(port_dn)) {

			phydev = of_phy_find_device(port_dn);

			if (phydev) {

				int addr = phydev->mdio.addr;



				phy_device_free(phydev);

				of_node_put(port_dn);

				fixed_phy_del(addr);

				fixed_phy_unregister(phydev);

			}

		}

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE