Unverified Commit 5bbe5434 authored Jul 17, 2019 by Paul Burton

MIPS: Annotate fall-through in kvm/emulate.c



kvm_compute_return_epc contains a switch statement with an intentional
fall-through from a case handling jal (jump and link) instructions to
one handling j (jump) instructions. With -Wimplicit-fallthrough this
triggers a compile error (due to -Werror being enabled for arch/mips).

This can be reproduced using malta_kvm_defconfig.

Fix this by annotating the intentional fall-through.

Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org

parent b8bea8a5

arch/mips/kvm/emulate.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -140,6 +140,7 @@ static int kvm_compute_return_epc(struct kvm_vcpu *vcpu, unsigned long instpc,
		/* These are unconditional and in j_format. */
		case jal_op:
		arch->gprs[31] = instpc + 8;
		/* fall through */
		case j_op:
		epc += 4;
		epc >>= 28;

Admin message