dmaengine: iop_adma: convert tasklets to use new tasklet_setup() API (5bbb671f) · Commits · 戴 / test

In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by:

Romain Perier <romain.perier@gmail.com> Signed-off-by:

Allen Pais <allen.lkml@gmail.com> Link: https://lore.kernel.org/r/20200831103542.305571-11-allen.lkml@gmail.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/iop-adma.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -238,9 +238,10 @@ iop_adma_slot_cleanup(struct iop_adma_chan *iop_chan)
		spin_unlock_bh(&iop_chan->lock);
		}

		static void iop_adma_tasklet(unsigned long data)
		static void iop_adma_tasklet(struct tasklet_struct *t)
		{
		struct iop_adma_chan iop_chan = (struct iop_adma_chan ) data;
		struct iop_adma_chan *iop_chan = from_tasklet(iop_chan, t,
		irq_tasklet);

		/* lockdep will flag depedency submissions as potentially
		* recursive locking, this is not the case as a dependency
		@@ -1351,8 +1352,7 @@ static int iop_adma_probe(struct platform_device *pdev)
		ret = -ENOMEM;
		goto err_free_iop_chan;
		}
		tasklet_init(&iop_chan->irq_tasklet, iop_adma_tasklet, (unsigned long)
		iop_chan);
		tasklet_setup(&iop_chan->irq_tasklet, iop_adma_tasklet);

		/* clear errors before enabling interrupts */
		iop_adma_device_clear_err_status(iop_chan);

Admin message