hrtimer: Update hrtimer base offsets each hrtimer_interrupt (5baefd6d) · Commits · 戴 / test

The update of the hrtimer base offsets on all cpus cannot be made atomically from the timekeeper.lock held and interrupt disabled region as smp function calls are not allowed there. clock_was_set(), which enforces the update on all cpus, is called either from preemptible process context in case of do_settimeofday() or from the softirq context when the offset modification happened in the timer interrupt itself due to a leap second. In both cases there is a race window for an hrtimer interrupt between dropping timekeeper lock, enabling interrupts and clock_was_set() issuing the updates. Any interrupt which arrives in that window will see the new time but operate on stale offsets. So we need to make sure that an hrtimer interrupt always sees a consistent state of time and offsets. ktime_get_update_offsets() allows us to get the current monotonic time and update the per cpu hrtimer base offsets from hrtimer_interrupt() to capture a consistent state of monotonic time and the offsets. The function replaces the existing ktime_get() calls in hrtimer_interrupt(). The overhead of the new function vs. ktime_get() is minimal as it just adds two store operations. This ensures that any changes to realtime or boottime offsets are noticed and stored into the per-cpu hrtimer base structures, prior to any hrtimer expiration and guarantees that timers are not expired early. Signed-off-by:

John Stultz <johnstul@us.ibm.com> Reviewed-by:

Ingo Molnar <mingo@kernel.org> Acked-by:

Peter Zijlstra <a.p.zijlstra@chello.nl> Acked-by:

Prarit Bhargava <prarit@redhat.com> Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1341960205-56738-8-git-send-email-johnstul@us.ibm.com Signed-off-by:

Thomas Gleixner <tglx@linutronix.de>

kernel/hrtimer.c

+14 −14

Original line number	Diff line number	Diff line
		@@ -657,6 +657,14 @@ static inline int hrtimer_enqueue_reprogram(struct hrtimer *timer,
		return 0;
		}

		static inline ktime_t hrtimer_update_base(struct hrtimer_cpu_base *base)
		{
		ktime_t *offs_real = &base->clock_base[HRTIMER_BASE_REALTIME].offset;
		ktime_t *offs_boot = &base->clock_base[HRTIMER_BASE_BOOTTIME].offset;

		return ktime_get_update_offsets(offs_real, offs_boot);
		}

		/*
		* Retrigger next event is called after clock was set
		*
		@@ -665,22 +673,12 @@ static inline int hrtimer_enqueue_reprogram(struct hrtimer *timer,
		static void retrigger_next_event(void *arg)
		{
		struct hrtimer_cpu_base *base = &__get_cpu_var(hrtimer_bases);
		struct timespec realtime_offset, xtim, wtm, sleep;

		if (!hrtimer_hres_active())
		return;

		/* Optimized out for !HIGH_RES */
		get_xtime_and_monotonic_and_sleep_offset(&xtim, &wtm, &sleep);
		set_normalized_timespec(&realtime_offset, -wtm.tv_sec, -wtm.tv_nsec);

		/* Adjust CLOCK_REALTIME offset */
		raw_spin_lock(&base->lock);
		base->clock_base[HRTIMER_BASE_REALTIME].offset =
		timespec_to_ktime(realtime_offset);
		base->clock_base[HRTIMER_BASE_BOOTTIME].offset =
		timespec_to_ktime(sleep);

		hrtimer_update_base(base);
		hrtimer_force_reprogram(base, 0);
		raw_spin_unlock(&base->lock);
		}
		@@ -710,7 +708,6 @@ static int hrtimer_switch_to_hres(void)
		base->clock_base[i].resolution = KTIME_HIGH_RES;

		tick_setup_sched_timer();

		/* "Retrigger" the interrupt to get things going */
		retrigger_next_event(NULL);
		local_irq_restore(flags);
		@@ -1264,7 +1261,7 @@ void hrtimer_interrupt(struct clock_event_device *dev)
		dev->next_event.tv64 = KTIME_MAX;

		raw_spin_lock(&cpu_base->lock);
		entry_time = now = ktime_get();
		entry_time = now = hrtimer_update_base(cpu_base);
		retry:
		expires_next.tv64 = KTIME_MAX;
		/*
		@@ -1342,9 +1339,12 @@ retry:
		* We need to prevent that we loop forever in the hrtimer
		* interrupt routine. We give it 3 attempts to avoid
		* overreacting on some spurious event.
		*
		* Acquire base lock for updating the offsets and retrieving
		* the current time.
		*/
		raw_spin_lock(&cpu_base->lock);
		now = ktime_get();
		now = hrtimer_update_base(cpu_base);
		cpu_base->nr_retries++;
		if (++retries < 3)
		goto retry;

Admin message