Commit 5ba4a25a authored Apr 03, 2015 by J. Bruce Fields

nfsd4: disallow ALLOCATE with special stateids



vfs_fallocate will hit a NULL dereference if the client tries an
ALLOCATE or DEALLOCATE with a special stateid.  Fix that.  (We also
depend on the open to have broken any conflicting leases or delegations
for us.)

(If it turns out we need to allow special stateid's then we could do a
temporary open here in the special-stateid case, as we do for read and
write.  For now I'm assuming it's not necessary.)

Fixes: 95d871f0 "nfsd: Add ALLOCATE support"
Cc: stable@vger.kernel.org
Cc: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent 9b3075c5

fs/nfsd/nfs4proc.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1030,6 +1030,8 @@ nfsd4_fallocate(struct svc_rqst rqstp, struct nfsd4_compound_state cstate,
		dprintk("NFSD: nfsd4_fallocate: couldn't process stateid!\n");
		return status;
		}
		if (!file)
		return nfserr_bad_stateid;

		status = nfsd4_vfs_fallocate(rqstp, &cstate->current_fh, file,
		fallocate->falloc_offset,

Admin message