Commit 5b9b0a80 authored Sep 21, 2018 by Nathan Chancellor Committed by David S. Miller Sep 21, 2018

decnet: Remove unnecessary check for dev->name

Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

net/decnet/dn_dev.c:1366:10: warning: address of array 'dev->name' will
always evaluate to 'true' [-Wpointer-bool-conversion]
                                dev->name ? dev->name : "???",
                                ~~~~~^~~~ ~
1 warning generated.

Link: https://github.com/ClangBuiltLinux/linux/issues/116


Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bccc1711

net/decnet/dn_dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1363,7 +1363,7 @@ static int dn_dev_seq_show(struct seq_file seq, void v)

		seq_printf(seq, "%-8s %1s %04u %04u %04lu %04lu"
		" %04hu %03d %02x %-10s %-7s %-7s\n",
		dev->name ? dev->name : "???",
		dev->name,
		dn_type2asc(dn_db->parms.mode),
		0, 0,
		dn_db->t3, dn_db->parms.t3,

Admin message