Commit 5b797980 authored Sep 09, 2020 by Paul Barker Committed by David S. Miller Sep 09, 2020

net: dsa: microchip: Implement recommended reset timing



The datasheet for the ksz9893 and ksz9477 switches recommend waiting at
least 100us after the de-assertion of reset before trying to program the
device through any interface.

Also switch the existing msleep() call to usleep_range() as recommended
in Documentation/timers/timers-howto.rst. The 2ms range used here is
somewhat arbitrary, as long as the reset is asserted for at least 10ms
we should be ok.

Signed-off-by: Paul Barker <pbarker@konsulko.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ade64eb5

drivers/net/dsa/microchip/ksz_common.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -400,8 +400,9 @@ int ksz_switch_register(struct ksz_device *dev,

		if (dev->reset_gpio) {
		gpiod_set_value_cansleep(dev->reset_gpio, 1);
		mdelay(10);
		usleep_range(10000, 12000);
		gpiod_set_value_cansleep(dev->reset_gpio, 0);
		usleep_range(100, 1000);
		}

		mutex_init(&dev->dev_mutex);

Admin message