Commit 5b7789e8 authored Jan 30, 2018 by Gustavo A. R. Silva Committed by David S. Miller Jan 31, 2018

openvswitch: meter: Use 64-bit arithmetic instead of 32-bit



Add suffix LL to constant 1000 in order to give the compiler
complete information about the proper arithmetic to use. Notice
that this constant is used in a context that expects an expression
of type long long int (64 bits, signed).

The expression (band->burst_size + band->rate) * 1000 is currently
being evaluated using 32-bit arithmetic.

Addresses-Coverity-ID: 1461563 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e4823fbd

net/openvswitch/meter.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -488,7 +488,7 @@ bool ovs_meter_execute(struct datapath dp, struct sk_buff skb,
	long long int max_bucket_size;		long long int max_bucket_size;

	band = &meter->bands[i];		band = &meter->bands[i];
	max_bucket_size = (band->burst_size + band->rate) * 1000;		max_bucket_size = (band->burst_size + band->rate) * 1000LL;

	band->bucket += delta_ms * band->rate;		band->bucket += delta_ms * band->rate;
	if (band->bucket > max_bucket_size)		if (band->bucket > max_bucket_size)

Admin message