Commit 5b69c237 authored Apr 07, 2020 by Dan Carpenter Committed by Enric Balletbo i Serra Apr 13, 2020

platform/chrome: cros_ec_sensorhub: Off by one in cros_sensorhub_send_sample()

The sensorhub->push_data[] array has sensorhub->sensor_num elements.
It's allocated in cros_ec_sensorhub_ring_add(). So the > should be >=
to prevent a read one element beyond the end of the array.

Fixes: 145d59ba ("platform/chrome: cros_ec_sensorhub: Add FIFO support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

parent a4638771

drivers/platform/chrome/cros_ec_sensorhub_ring.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -40,7 +40,7 @@ cros_sensorhub_send_sample(struct cros_ec_sensorhub *sensorhub,
		int id = sample->sensor_id;
		struct iio_dev *indio_dev;

		if (id > sensorhub->sensor_num)
		if (id >= sensorhub->sensor_num)
		return -EINVAL;

		cb = sensorhub->push_data[id].push_data_cb;