Unverified Commit 5b684514 authored by Jason Yan's avatar Jason Yan Committed by Mark Brown
Browse files

spi: a3700: make a3700_spi_init() return void 



Fix the following coccicheck warning:

drivers/spi/spi-armada-3700.c:283:8-11: Unneeded variable: "ret". Return
"0" on line 315

Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Link: https://lore.kernel.org/r/20200506061911.19923-1-yanaijie@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c48e0c53

drivers/spi/spi-armada-3700.c

+3 −7
Original line number Diff line number Diff line
@@ -276,11 +276,11 @@ static int a3700_spi_fifo_flush(struct a3700_spi *a3700_spi) 
	return -ETIMEDOUT;

}



static int a3700_spi_init(struct a3700_spi *a3700_spi)

static void a3700_spi_init(struct a3700_spi *a3700_spi)

{

	struct spi_master *master = a3700_spi->master;

	u32 val;

	int i, ret = 0;

	int i;



	/* Reset SPI unit */

	val = spireg_read(a3700_spi, A3700_SPI_IF_CFG_REG);
@@ -311,8 +311,6 @@ static int a3700_spi_init(struct a3700_spi *a3700_spi) 
	/* Mask the interrupts and clear cause bits */

	spireg_write(a3700_spi, A3700_SPI_INT_MASK_REG, 0);

	spireg_write(a3700_spi, A3700_SPI_INT_STAT_REG, ~0U);



	return ret;

}



static irqreturn_t a3700_spi_interrupt(int irq, void *dev_id)
@@ -886,9 +884,7 @@ static int a3700_spi_probe(struct platform_device *pdev) 
	master->min_speed_hz = DIV_ROUND_UP(clk_get_rate(spi->clk),

						A3700_SPI_MAX_PRESCALE);



	ret = a3700_spi_init(spi);

	if (ret)

		goto error_clk;

	a3700_spi_init(spi);



	ret = devm_request_irq(dev, spi->irq, a3700_spi_interrupt, 0,

			       dev_name(dev), master);

CRA Git | Maintained and supported by SUSTech CRA and CCSE