Commit 5b61d50a authored Feb 27, 2019 by Konstantin Khlebnikov Committed by Ingo Molnar Apr 19, 2019

sched/core: Handle overflow in cpu_shares_write_u64



Bit shift in scale_load() could overflow shares. This patch saturates
it to MAX_SHARES like following sched_group_set_shares().

Example:

 # echo 9223372036854776832 > cpu.shares
 # cat cpu.shares

Before patch: 1024
After pattch: 262144

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/155125501891.293431.3345233332801109696.stgit@buzz


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 1a010e29

kernel/sched/core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -6507,6 +6507,8 @@ static void cpu_cgroup_attach(struct cgroup_taskset *tset)
		static int cpu_shares_write_u64(struct cgroup_subsys_state *css,
		struct cftype *cftype, u64 shareval)
		{
		if (shareval > scale_load_down(ULONG_MAX))
		shareval = MAX_SHARES;
		return sched_group_set_shares(css_tg(css), scale_load(shareval));
		}

Admin message