Commit 5b55072f authored May 13, 2018 by Joel Fernandes (Google) Committed by Paul E. McKenney Jul 12, 2018

rcu: Produce last "CleanupMore" trace only if late-breaking request

Currently Tree RCU's clean-up code emits a "CleanupMore" trace event in
response to late-arriving grace-period requests even if the grace period
was already requested. This makes "CleanupMore" show up an extra time (in
addition to once for each rcu_node structure that was previously marked
with the request), and for no good reason. This commit therefore avoids
emitting this trace message unless the the only request for this next
grace period arrived during or after the cleanup scan of the rcu_node
structures.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

parent a2165e41

kernel/rcu/tree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2069,7 +2069,7 @@ static void rcu_gp_cleanup(struct rcu_state *rsp)
		rsp->gp_state = RCU_GP_IDLE;
		/* Check for GP requests since above loop. */
		rdp = this_cpu_ptr(rsp->rda);
		if (ULONG_CMP_LT(rnp->gp_seq, rnp->gp_seq_needed)) {
		if (!needgp && ULONG_CMP_LT(rnp->gp_seq, rnp->gp_seq_needed)) {
		trace_rcu_this_gp(rnp, rdp, rnp->gp_seq_needed,
		TPS("CleanupMore"));
		needgp = true;

Admin message