Commit 5b39939a authored by Frederic Weisbecker's avatar Frederic Weisbecker
Browse files

nohz: Move ts->idle_calls incrementation into strict idle logic 



Since we want to prepare for making the nohz API to work further
the idle case, we need to pull ts->idle_calls incrementation up to
the callers in idle.

To perform this, we split tick_nohz_stop_sched_tick() in two parts:
a first one that checks if we can really stop the tick for idle,
and another that actually stops it. Then from the callers in idle,
we check if we can stop the tick and only then we increment idle_calls
and finally relay to the nohz API that won't care about these details
anymore.

Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Avi Kivity <avi@redhat.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Geoff Levand <geoff@infradead.org>
Cc: Gilad Ben Yossef <gilad@benyossef.com>
Cc: Hakan Akkan <hakanakkan@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Kevin Hilman <khilman@ti.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Sven-Thorsten Dietrich <thebigcorporation@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
parent f5d411c9

kernel/time/tick-sched.c

+47 −39
Original line number Diff line number Diff line
@@ -271,47 +271,15 @@ u64 get_cpu_iowait_time_us(int cpu, u64 *last_update_time) 
}

EXPORT_SYMBOL_GPL(get_cpu_iowait_time_us);



static void tick_nohz_stop_sched_tick(struct tick_sched *ts, ktime_t now)

static void tick_nohz_stop_sched_tick(struct tick_sched *ts,

				      ktime_t now, int cpu)

{

	unsigned long seq, last_jiffies, next_jiffies, delta_jiffies;

	ktime_t last_update, expires;

	struct clock_event_device *dev = __get_cpu_var(tick_cpu_device).evtdev;

	u64 time_delta;

	int cpu;



	cpu = smp_processor_id();

	ts = &per_cpu(tick_cpu_sched, cpu);



	/*

	 * If this cpu is offline and it is the one which updates

	 * jiffies, then give up the assignment and let it be taken by

	 * the cpu which runs the tick timer next. If we don't drop

	 * this here the jiffies might be stale and do_timer() never

	 * invoked.

	 */

	if (unlikely(!cpu_online(cpu))) {

		if (cpu == tick_do_timer_cpu)

			tick_do_timer_cpu = TICK_DO_TIMER_NONE;

	}



	if (unlikely(ts->nohz_mode == NOHZ_MODE_INACTIVE))

		return;



	if (need_resched())

		return;



	if (unlikely(local_softirq_pending() && cpu_online(cpu))) {

		static int ratelimit;



		if (ratelimit < 10) {

			printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",

			       (unsigned int) local_softirq_pending());

			ratelimit++;

		}

		return;

	}



	ts->idle_calls++;

	/* Read jiffies and the time when jiffies were updated last */

	do {

		seq = read_seqbegin(&xtime_lock);
@@ -441,17 +409,57 @@ out: 
	ts->sleep_length = ktime_sub(dev->next_event, now);

}



static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)

{

	/*

	 * If this cpu is offline and it is the one which updates

	 * jiffies, then give up the assignment and let it be taken by

	 * the cpu which runs the tick timer next. If we don't drop

	 * this here the jiffies might be stale and do_timer() never

	 * invoked.

	 */

	if (unlikely(!cpu_online(cpu))) {

		if (cpu == tick_do_timer_cpu)

			tick_do_timer_cpu = TICK_DO_TIMER_NONE;

	}



	if (unlikely(ts->nohz_mode == NOHZ_MODE_INACTIVE))

		return false;



	if (need_resched())

		return false;



	if (unlikely(local_softirq_pending() && cpu_online(cpu))) {

		static int ratelimit;



		if (ratelimit < 10) {

			printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",

			       (unsigned int) local_softirq_pending());

			ratelimit++;

		}

		return false;

	}



	return true;

}



static void __tick_nohz_idle_enter(struct tick_sched *ts)

{

	ktime_t now;

	int cpu = smp_processor_id();



	now = tick_nohz_start_idle(cpu, ts);



	if (can_stop_idle_tick(cpu, ts)) {

		int was_stopped = ts->tick_stopped;



	now = tick_nohz_start_idle(smp_processor_id(), ts);

	tick_nohz_stop_sched_tick(ts, now);

		ts->idle_calls++;

		tick_nohz_stop_sched_tick(ts, now, cpu);



		if (!was_stopped && ts->tick_stopped)

			ts->idle_jiffies = ts->last_jiffies;

	}

}



/**

 * tick_nohz_idle_enter - stop the idle tick from the idle task

CRA Git | Maintained and supported by SUSTech CRA and CCSE