Commit 5b21533b authored Aug 07, 2013 by Lars Poeschel Committed by Linus Walleij Aug 16, 2013

gpio: adnp: Fix segfault if request_threaded_irq fails



In case request_threaded_irq inside adnp_irq_setup fails, the driver
segfaults. This is because irq_domain_remove is called twice with
the same pointer. First time in adnp_irq_setup and then a second time
after leaving adnp_irq_setup in the error path of adnp_i2c_probe
inside adnp_teardown.
This fixes this by removing the call to irq_domain_remove from
adnp_irq_setup.

Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent b3abebc7

drivers/gpio/gpio-adnp.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -490,15 +490,11 @@ static int adnp_irq_setup(struct adnp *adnp)
		if (err != 0) {
		dev_err(chip->dev, "can't request IRQ#%d: %d\n",
		adnp->client->irq, err);
		goto error;
		return err;
		}

		chip->to_irq = adnp_gpio_to_irq;
		return 0;

		error:
		irq_domain_remove(adnp->domain);
		return err;
		}

		static void adnp_irq_teardown(struct adnp *adnp)

Admin message