Commit 5b1dc0fd authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf intel-pt: Add support for samples to contain IPC ratio 



Copy the incremental instruction count and cycle count onto 'instructions'
and 'branches' samples.

Because Intel PT does not update the cycle count on every branch or
instruction, the incremental values will often be zero.

When there are values, they will be the number of instructions and
number of cycles since the last update, and thus represent the average
IPC since the last IPC value.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/20190520113728.14389-8-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 61d276f4

tools/perf/util/intel-pt.c

+29 −0
Original line number Diff line number Diff line
@@ -157,6 +157,12 @@ struct intel_pt_queue { 
	u32 flags;

	u16 insn_len;

	u64 last_insn_cnt;

	u64 ipc_insn_cnt;

	u64 ipc_cyc_cnt;

	u64 last_in_insn_cnt;

	u64 last_in_cyc_cnt;

	u64 last_br_insn_cnt;

	u64 last_br_cyc_cnt;

	char insn[INTEL_PT_INSN_BUF_SZ];

};
@@ -1162,6 +1168,13 @@ static int intel_pt_synth_branch_sample(struct intel_pt_queue *ptq) 
		sample.branch_stack = (struct branch_stack *)&dummy_bs;

	}



	sample.cyc_cnt = ptq->ipc_cyc_cnt - ptq->last_br_cyc_cnt;

	if (sample.cyc_cnt) {

		sample.insn_cnt = ptq->ipc_insn_cnt - ptq->last_br_insn_cnt;

		ptq->last_br_insn_cnt = ptq->ipc_insn_cnt;

		ptq->last_br_cyc_cnt = ptq->ipc_cyc_cnt;

	}



	return intel_pt_deliver_synth_b_event(pt, event, &sample,

					      pt->branches_sample_type);

}
@@ -1217,6 +1230,13 @@ static int intel_pt_synth_instruction_sample(struct intel_pt_queue *ptq) 
	sample.stream_id = ptq->pt->instructions_id;

	sample.period = ptq->state->tot_insn_cnt - ptq->last_insn_cnt;



	sample.cyc_cnt = ptq->ipc_cyc_cnt - ptq->last_in_cyc_cnt;

	if (sample.cyc_cnt) {

		sample.insn_cnt = ptq->ipc_insn_cnt - ptq->last_in_insn_cnt;

		ptq->last_in_insn_cnt = ptq->ipc_insn_cnt;

		ptq->last_in_cyc_cnt = ptq->ipc_cyc_cnt;

	}



	ptq->last_insn_cnt = ptq->state->tot_insn_cnt;



	return intel_pt_deliver_synth_event(pt, ptq, event, &sample,
@@ -1488,6 +1508,15 @@ static int intel_pt_sample(struct intel_pt_queue *ptq) 


	ptq->have_sample = false;



	if (ptq->state->tot_cyc_cnt > ptq->ipc_cyc_cnt) {

		/*

		 * Cycle count and instruction count only go together to create

		 * a valid IPC ratio when the cycle count changes.

		 */

		ptq->ipc_insn_cnt = ptq->state->tot_insn_cnt;

		ptq->ipc_cyc_cnt = ptq->state->tot_cyc_cnt;

	}



	if (pt->sample_pwr_events && (state->type & INTEL_PT_PWR_EVT)) {

		if (state->type & INTEL_PT_CBR_CHG) {

			err = intel_pt_synth_cbr_sample(ptq);

CRA Git | Maintained and supported by SUSTech CRA and CCSE