Commit 5b11ebed authored Dec 03, 2016 by Pan Bian Committed by Greg Kroah-Hartman Jan 11, 2017

extcon: return error code on failure

Function get_zeroed_page() returns a NULL pointer if there is no enough
memory. In function extcon_sync(), it returns 0 if the call to
get_zeroed_page() fails. The return value 0 indicates success in the
context, which is incosistent with the execution status. This patch
fixes the bug by returning -ENOMEM.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188611



Signed-off-by: Pan Bian <bianpan2016@163.com>
Fixes: a580982f
Cc: stable <stable@vger.kernel.org>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 488debb9

drivers/extcon/extcon.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id)
	dev_err(&edev->dev, "out of memory in extcon_set_state\n");		dev_err(&edev->dev, "out of memory in extcon_set_state\n");
	kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE);		kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE);

	return 0;		return -ENOMEM;
	}		}

	length = name_show(&edev->dev, NULL, prop_buf);		length = name_show(&edev->dev, NULL, prop_buf);

Admin message