Commit 5b0620df authored Jul 08, 2013 by Jean Delvare Committed by Jean Delvare Jul 08, 2013

hwmon: (lm63) Drop redundant safety on cache lifetime



time_after (as opposed to time_after_equal) already ensures that the
cache lifetime is at least as much as requested. There is no point in
manually adding another jiffy to that value, and this can confuse the
reader into wrong interpretation.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Imre Deak <imre.deak@intel.com>

parent 78c2c2fe

drivers/hwmon/lm63.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -247,9 +247,8 @@ static struct lm63_data lm63_update_device(struct device dev)

		mutex_lock(&data->update_lock);

		next_update = data->last_updated
		+ msecs_to_jiffies(data->update_interval) + 1;

		next_update = data->last_updated +
		msecs_to_jiffies(data->update_interval);
		if (time_after(jiffies, next_update) \|\| !data->valid) {
		if (data->config & 0x04) { /* tachometer enabled */
		/* order matters for fan1_input */

Admin message