Commit 5b009673 authored Dec 04, 2019 by Masahiro Yamada Committed by Linus Torvalds Dec 04, 2019

arch: ipcbuf.h: make uapi asm/ipcbuf.h self-contained

Userspace cannot compile <asm/ipcbuf.h> due to some missing type
definitions.  For example, building it for x86 fails as follows:

    CC      usr/include/asm/ipcbuf.h.s
  In file included from usr/include/asm/ipcbuf.h:1:0,
                   from <command-line>:32:
  usr/include/asm-generic/ipcbuf.h:21:2: error: unknown type name `__kernel_key_t'
    __kernel_key_t  key;
    ^~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:22:2: error: unknown type name `__kernel_uid32_t'
    __kernel_uid32_t uid;
    ^~~~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:23:2: error: unknown type name `__kernel_gid32_t'
    __kernel_gid32_t gid;
    ^~~~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:24:2: error: unknown type name `__kernel_uid32_t'
    __kernel_uid32_t cuid;
    ^~~~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:25:2: error: unknown type name `__kernel_gid32_t'
    __kernel_gid32_t cgid;
    ^~~~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:26:2: error: unknown type name `__kernel_mode_t'
    __kernel_mode_t  mode;
    ^~~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:28:35: error: `__kernel_mode_t' undeclared here (not in a function)
    unsigned char  __pad1[4 - sizeof(__kernel_mode_t)];
                                     ^~~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:31:2: error: unknown type name `__kernel_ulong_t'
    __kernel_ulong_t __unused1;
    ^~~~~~~~~~~~~~~~
  usr/include/asm-generic/ipcbuf.h:32:2: error: unknown type name `__kernel_ulong_t'
    __kernel_ulong_t __unused2;
    ^~~~~~~~~~~~~~~~

It is just a matter of missing include directive.

Include <linux/posix_types.h> to make it self-contained, and add it to
the compile-test coverage.

Link: http://lkml.kernel.org/r/20191030063855.9989-1-yamada.masahiro@socionext.com


Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ce5c31db

arch/s390/include/uapi/asm/ipcbuf.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -2,6 +2,8 @@
		#ifndef __S390_IPCBUF_H__
		#define __S390_IPCBUF_H__

		#include <linux/posix_types.h>

		/*
		* The user_ipc_perm structure for S/390 architecture.
		* Note extra padding because this structure is passed back and forth

arch/sparc/include/uapi/asm/ipcbuf.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -2,6 +2,8 @@
		#ifndef __SPARC_IPCBUF_H
		#define __SPARC_IPCBUF_H

		#include <linux/posix_types.h>

		/*
		* The ipc64_perm structure for sparc/sparc64 architecture.
		* Note extra padding because this structure is passed back and forth

arch/xtensa/include/uapi/asm/ipcbuf.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -12,6 +12,8 @@
		#ifndef _XTENSA_IPCBUF_H
		#define _XTENSA_IPCBUF_H

		#include <linux/posix_types.h>

		/*
		* Pad space is left for:
		* - 32-bit mode_t and seq

include/uapi/asm-generic/ipcbuf.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -2,6 +2,8 @@
		#ifndef __ASM_GENERIC_IPCBUF_H
		#define __ASM_GENERIC_IPCBUF_H

		#include <linux/posix_types.h>

		/*
		* The generic ipc64_perm structure:
		* Note extra padding because this structure is passed back and forth

usr/include/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -16,7 +16,6 @@ override c_flags = $(UAPI_CFLAGS) -Wp,-MD,$(depfile) -I$(objtree)/usr/include
		# Please consider to fix the header first.
		#
		# Sorted alphabetically.
		header-test- += asm/ipcbuf.h
		header-test- += asm/msgbuf.h
		header-test- += asm/sembuf.h
		header-test- += asm/shmbuf.h

Admin message