ALSA: cs4281: Support PCM sync_stop (5afff8c1) · Commits · 戴 / test

The driver invokes snd_pcm_period_elapsed() simply from the interrupt handler. Set card->sync_irq for enabling the missing sync_stop PCM operation, as well as removing the superfluous synchronize_irq() call. Link: https://lore.kernel.org/r/20191210063454.31603-12-tiwai@suse.de Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/pci/cs4281.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1268,9 +1268,6 @@ static int snd_cs4281_free(struct cs4281 *chip)
		{
		snd_cs4281_free_gameport(chip);

		if (chip->irq >= 0)
		synchronize_irq(chip->irq);

		/* Mask interrupts */
		snd_cs4281_pokeBA0(chip, BA0_HIMR, 0x7fffffff);
		/* Stop the DLL Clock logic. */
		@@ -1352,6 +1349,7 @@ static int snd_cs4281_create(struct snd_card *card,
		return -ENOMEM;
		}
		chip->irq = pci->irq;
		card->sync_irq = chip->irq;

		tmp = snd_cs4281_chip_init(chip);
		if (tmp) {
		@@ -1600,7 +1598,6 @@ static int snd_cs4281_chip_init(struct cs4281 *chip)
		BA0_HISR_DMA(1) \|
		BA0_HISR_DMA(2) \|
		BA0_HISR_DMA(3)));
		synchronize_irq(chip->irq);

		return 0;
		}

Admin message