Commit 5ae89078 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

staging: most: cdev: add missing check for cdev_add failure 



Currently the call to cdev_add is missing a check for failure. Fix this by
checking for failure and exiting via a new error path that ensures the
allocated comp_channel struct is kfree'd.

Detected by CoverityScan, CID#1462359 ("Unchecked return value")

Fixes: 9bc79bbc ("Staging: most: add MOST driver's aim-cdev module")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent da17ad1e

drivers/staging/most/cdev/cdev.c

+4 −1
Original line number Diff line number Diff line
@@ -453,7 +453,9 @@ static int comp_probe(struct most_interface *iface, int channel_id, 
	c->devno = MKDEV(comp.major, current_minor);

	cdev_init(&c->cdev, &channel_fops);

	c->cdev.owner = THIS_MODULE;

	cdev_add(&c->cdev, c->devno, 1);

	retval = cdev_add(&c->cdev, c->devno, 1);

	if (retval < 0)

		goto err_free_c;

	c->iface = iface;

	c->cfg = cfg;

	c->channel_id = channel_id;
@@ -485,6 +487,7 @@ err_free_kfifo_and_del_list: 
	list_del(&c->list);

err_del_cdev_and_free_channel:

	cdev_del(&c->cdev);

err_free_c:

	kfree(c);

err_remove_ida:

	ida_simple_remove(&comp.minor_id, current_minor);

CRA Git | Maintained and supported by SUSTech CRA and CCSE