Commit 5ac75688 authored by Sam Ravnborg's avatar Sam Ravnborg Committed by David S. Miller
Browse files

sparc32: fix sparse warnings in sun4d_irq.c 



Fix following warnings:
sun4d_irq.c:146:6: warning: symbol 'sun4d_handler_irq' was not declared. Should it be static?
sun4d_irq.c:239:17: warning: symbol 'sun4d_irq' was not declared. Should it be static?
sun4d_irq.c:288:14: warning: symbol '_sun4d_build_device_irq' was not declared. Should it be static?
sun4d_irq.c:323:14: warning: symbol 'sun4d_build_device_irq' was not declared. Should it be static?
sun4d_irq.c:386:14: warning: symbol 'sun4d_build_timer_irq' was not declared. Should it be static?
sun4d_irq.c:482:13: warning: symbol 'sun4d_init_sbi_irq' was not declared. Should it be static?

Apply static when applicable, otherwise add prototype

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b399177

arch/sparc/include/asm/irq_32.h

+1 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
#define irq_canonicalize(irq)	(irq)



extern void __init init_IRQ(void);

void __init sun4d_init_sbi_irq(void);



#define NO_IRQ		0xffffffff

arch/sparc/kernel/irq.h

+3 −0
Original line number Diff line number Diff line
@@ -85,6 +85,9 @@ unsigned long leon_get_irqmask(unsigned int irq); 
/* sun4m_irq.c */

void sun4m_nmi(struct pt_regs *regs);



/* sun4d_irq.c */

void sun4d_handler_irq(unsigned int pil, struct pt_regs *regs);



#ifdef CONFIG_SMP



/* All SUN4D IPIs are sent on this IRQ, may be shared with hard IRQs */

arch/sparc/kernel/sun4d_irq.c

+9 −8
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static void sun4d_sbus_handler_irq(int sbusl) 
	}

}



void sun4d_handler_irq(int pil, struct pt_regs *regs)

void sun4d_handler_irq(unsigned int pil, struct pt_regs *regs)

{

	struct pt_regs *old_regs;

	/* SBUS IRQ level (1 - 7) */
@@ -236,7 +236,7 @@ static void sun4d_shutdown_irq(struct irq_data *data) 
	irq_unlink(data->irq);

}



struct irq_chip sun4d_irq = {

static struct irq_chip sun4d_irq = {

	.name		= "sun4d",

	.irq_startup	= sun4d_startup_irq,

	.irq_shutdown	= sun4d_shutdown_irq,
@@ -285,7 +285,7 @@ static void __init sun4d_load_profile_irqs(void) 
	}

}



unsigned int _sun4d_build_device_irq(unsigned int real_irq,

static unsigned int _sun4d_build_device_irq(unsigned int real_irq,

                                            unsigned int pil,

                                            unsigned int board)

{
@@ -320,7 +320,7 @@ err_out: 






unsigned int sun4d_build_device_irq(struct platform_device *op,

static unsigned int sun4d_build_device_irq(struct platform_device *op,

                                           unsigned int real_irq)

{

	struct device_node *dp = op->dev.of_node;
@@ -383,7 +383,8 @@ err_out: 
	return irq;

}



unsigned int sun4d_build_timer_irq(unsigned int board, unsigned int real_irq)

static unsigned int sun4d_build_timer_irq(unsigned int board,

                                          unsigned int real_irq)

{

	return _sun4d_build_device_irq(real_irq, real_irq, board);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE