Commit 5abcbc7b authored Dec 10, 2018 by Guenter Roeck

hwmon: (tc74) Use permission specific SENSOR[_DEVICE]_ATTR variants

Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readability, and to reduce the chance of inconsistencies.

Also replace any remaining S_<PERMS> in the driver with octal values.

The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/

.

This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 1acd2e29

drivers/hwmon/tc74.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -86,7 +86,7 @@ ret_unlock:
		return ret;
		}

		static ssize_t show_temp_input(struct device *dev,
		static ssize_t temp_input_show(struct device *dev,
		struct device_attribute attr, char buf)
		{
		struct tc74_data *data = dev_get_drvdata(dev);
		@@ -98,7 +98,7 @@ static ssize_t show_temp_input(struct device *dev,

		return sprintf(buf, "%d\n", data->temp_input * 1000);
		}
		static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp_input, NULL, 0);
		static SENSOR_DEVICE_ATTR_RO(temp1_input, temp_input, 0);

		static struct attribute *tc74_attrs[] = {
		&sensor_dev_attr_temp1_input.dev_attr.attr,

Admin message