Commit 5aa63f03 authored Apr 12, 2009 by Almer S. Tigelaar Committed by Len Brown Apr 23, 2009

ACPI: EC: Fix ACPI EC resume non-query interrupt message



When resuming from standby (on a laptop) I see the following message in
my kernel.log:
"ACPI: EC: non-query interrupt received, switching to interrupt mode"
This apparently prevented sony-laptop to properly restore the brightness
level on resume.

The cause: In drivers/acpi/ec.c the acpi_ec_suspend function clears the
GPE mode bit, but this is not restored in acpi_ec_resume (the function
below it). The patch below fixes this by properly restoring the GPE_MODE
bit. Tested and confirmed to work.

Signed-off-by: Almer S. Tigelaar <almer@gnome.org>
Signed-off-by: Mattia Dongili <malattia@linux.it>
Acked-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>

parent a83021a2

drivers/acpi/ec.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1065,6 +1065,7 @@ static int acpi_ec_resume(struct acpi_device *device)
		struct acpi_ec *ec = acpi_driver_data(device);
		/* Enable use of GPE back */
		clear_bit(EC_FLAGS_NO_GPE, &ec->flags);
		set_bit(EC_FLAGS_GPE_MODE, &ec->flags);
		acpi_enable_gpe(NULL, ec->gpe);
		return 0;
		}

Admin message